rootstrap / i18n_linter

Rails i18n Linter Gem
https://rootstrap.com
MIT License
44 stars 2 forks source link

[Bug] Not working on Ruby MRI 3.0.0 #38

Open megatux opened 2 years ago

megatux commented 2 years ago

Bug report:

Installed on Ruby 3.0.0 and ran with error:

➜  i18n_linter git:(master) ✗ asdf local ruby 3.0.0
➜  i18n_linter git:(master) ✗ i18n_linter          
<internal:/Users/megatux/.asdf/installs/ruby/3.0.0/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require': cannot load such file -- mime/types (LoadError)
    from <internal:/Users/megatux/.asdf/installs/ruby/3.0.0/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
    from /Users/megatux/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/i18n_linter-0.1.1/lib/i18n_linter/rules/mime_type.rb:3:in `<top (required)>'
    from <internal:/Users/megatux/.asdf/installs/ruby/3.0.0/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
    from <internal:/Users/megatux/.asdf/installs/ruby/3.0.0/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
    from /Users/megatux/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/i18n_linter-0.1.1/lib/i18n_linter.rb:19:in `<top (required)>'
    from <internal:/Users/megatux/.asdf/installs/ruby/3.0.0/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
    from <internal:/Users/megatux/.asdf/installs/ruby/3.0.0/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
    from /Users/megatux/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/i18n_linter-0.1.1/exe/i18n_linter:3:in `<top (required)>'
    from /Users/megatux/.asdf/installs/ruby/3.0.0/bin/i18n_linter:23:in `load'
    from /Users/megatux/.asdf/installs/ruby/3.0.0/bin/i18n_linter:23:in `<main>'

Should work

Don't work

master

Ruby MRI v3.0.0

megatux commented 2 years ago

I think in Ruby 3 the "mime/types" gem was removed from the bundled gems. If I open an irb session and type require 'mime/types' it fails with same error.

megatux commented 2 years ago

After installing

gem install mime-types

I'm able to use the i18n_linter comment, so we should add it to the dependencies, I guess.