Closed mcousillas6 closed 5 years ago
@glm4 Moya has multipart and base64 uploads already implemented, we would need to update those to use moya's instead of the custom ones that we have now
@glm4 Moya has multipart and base64 uploads already implemented, we would need to update those to use moya's instead of the custom ones that we have now
Sounds good! 🙌
1 Warning | |
---|---|
:warning: | Be careful, maybe this PR it’s too big |
Generated by :no_entry_sign: Danger
Nice work! Looks very good :clap:
Description:
Refactored the networking layer using Moya as a layer on top of Alamofire:
ApiService
protocol andBaseApiService
Class, which implement default behavior for making http requests (custom decoding, error handling, logging, etc.)TargetType+Base
extensions to Moya`s own Target type to have default headers, base URL path and some helpers for body params.UserResource
(api spec) andUserService
(the actual api calls)Added default custom decoding for errors with the
APIError
struct to try and decode standard rails error structures.Notes: