rootstrap / ios-base

Boilerplate for new iOS projects using Swift 5. Provides a handful of functionalities.
https://rootstrap.com/
MIT License
258 stars 63 forks source link

Wrong type inference in AnalyticsManager services variable. #157

Closed glm4 closed 4 years ago

glm4 commented 4 years ago

https://github.com/rootstrap/ios-base/blob/3a8b9828f3e7aa4db892dc75c1f99fe9293d6581/ios-base/Analytics/AnalyticsManager.swift#L22

The services variable type should be [AnalyticsService] so the declaration should be changed to:

open var services: [AnalyticsService] = [FirebaseAnalyticsService()]