Implement FirstViewController programmatically

rootstrap / ios-base

Boilerplate for new iOS projects using Swift 5. Provides a handful of functionalities.

https://rootstrap.com/

MIT License

256 stars 63 forks source link

Implement FirstViewController programmatically #180

Closed kstoletniy closed 2 years ago

kstoletniy commented 3 years ago

Description:

Delete FirstViewController from storyboard
Implement FirstViewController programmatically
Define useful resources like colors, localizable strings and font
Define useful helpers for constraints and constant

Notes:

The rest of the viewControllers will be implemented in the next PR

Tasks:

ISSUE-177

Preview:

Simulator Screen Shot - iPhone Xs Max - 2021-07-13 at 13 41 17

glm4 commented 3 years ago

@kstoletniy Please add the issue that is being fixed to the description of the PR.

kstoletniy commented 3 years ago

@kstoletniy Please add the issue that is being fixed to the description of the PR.

@glm4 it's already added under Task section

glm4 commented 3 years ago

@kstoletniy Please add the issue that is being fixed to the description of the PR.

@glm4 it's already added under Task section

I missed it, my bad. I guess that we are not using the right PR template 😬

kstoletniy commented 3 years ago

@glm4 sorry, i don't get the comment #180 (comment) what is the point to check the view has a parent view and add it if is missing?

What i think that we need to check if the subview to be centred is added to the view, like this:

    if !subviews.contains(subview) {
      addSubview(subview)
    }

glm4 commented 3 years ago

@glm4 sorry, i don't get the comment #180 (comment) what is the point to check the view has a parent view and add it if is missing?

What i think that we need to check if the subview to be centred is added to the view, like this:
    if !subviews.contains(subview) {
      addSubview(subview)
    }

For better tracking I will reply this in the comment thread. Please do the same we can continue the conversation there.

kstoletniy commented 3 years ago

@glm4 sorry, i don't get the comment #180 (comment) what is the point to check the view has a parent view and add it if is missing? What i think that we need to check if the subview to be centred is added to the view, like this:
    if !subviews.contains(subview) {
      addSubview(subview)
    }
For better tracking I will reply this in the comment thread. Please do the same we can continue the conversation there.

git bug 😂 it didn't allow me to follow in the thread