search

rootstrap / ios-base

Boilerplate for new iOS projects using Swift 5. Provides a handful of functionalities.
https://rootstrap.com/
MIT License
262 stars 63 forks source link

Deprecating Fastlane #194

Open LetoFranco opened 2 years ago

LetoFranco commented 2 years ago

Description:

Motivation

The motivation behind this change is to have a code base from which we can decide and add our decisions in each project on top of the base, without having to double check after using the script to see what we should have and what we should delete.

For example: I think it's preferable not to have commented decisions in the readme, because it's similar to having commented code.

Alternative 1

Generate an issue in Github to create a notion page to store how to install and integrate Fastlane to a project.

Generate another issue to find a way to store the fastlane configuration file in some project to show how it is integrated.

Alternative 2

Another solution, could be to modify the script to add a check to ask if you want to keep fastlane or bitrise or leave it custom.

In case you decide to go for fastlane, see if it is installed or install it, and if not, remove the fastlane traces.

glm4 commented 2 years ago

@LetoFranco what's the motivation for this change? The last think I know is that we want the ios-base to be an example of how to configure our CI/CD workflows with Fastlane.

LetoFranco commented 2 years ago

@LetoFranco what's the motivation for this change? The last think I know is that we want the ios-base to be an example of how to configure our CI/CD workflows with Fastlane.

Hey @glm4, i added more details to the description in order to give more visibility about the motivations of the change.

glm4 commented 2 years ago

@LetoFranco what's the motivation for this change? The last think I know is that we want the ios-base to be an example of how to configure our CI/CD workflows with Fastlane.

Hey @glm4, i added more details to the description in order to give more visibility about the motivations of the change.

I think we should discuss this on the next iOS Roundtable as a team, and take a better look at the possible advantages and disadvantages.