Closed aguscha333 closed 6 years ago
@ericnpc I agree
@ericnpc Please see the comments above about the spinner. We are not replacing our classic spinner for the network indicator. This are changes to release the ios-base as clean and generic as possible. We can have our spinner logic in a separated branch so we can use it as before though.
@fernandatoledo maybe we can do something better: get the bundle name of the app from the .plist and use that var + "session", "user" or any key so the next time a developer use this repo the keys are updated automatically using the name of the actual project. WDYT? @glm4 @aguscha333 ? ( I think $(PRODUCT_NAME)
is the build setting variable that we can use from the plist)
That's much better!!! Great idea @pMalvasio 💪
@pMalvasio, @aguscha333 I think we should think a bit better this option before including it in the base. Im thinking in possible issues this could bring to the base since it is not tested yet, target name changes, weird target names, etc.
In this PR:
Updated project for open-source release.
Main changes:
Rename of project from swift-base to ios-base and all it's appearances.
Pods Removed:
showSpinner(message: "VC spinner")
is nowUIApplication.showNetworkActivity()
and(self.)hideSpinner()
is nowUIApplication.hideNetworkActivity()
.Fixes:
Main.storyboard
theFirstViewController
had a testView and textView that were removed for a cleaner look.