Fix/code climate issues - Githubissues

rootstrap / ios-base

Boilerplate for new iOS projects using Swift 5. Provides a handful of functionalities.

https://rootstrap.com/

MIT License

259 stars 63 forks source link

Fix/code climate issues #81

Closed glm4 closed 6 years ago

glm4 commented 6 years ago

Code climate issues and enhancements

Description:

This PR includes a refactor for some methods in the APIClient class in order to:
- Fix issues from Code Climate.
- Improve dictionary serializer logic and responses handling.
- Decouple SwiftyJSON from the dictionary serializer. Now using the native JSONSerialization class.
Also fixes tests based on the actual API responses and the improved empty body validation in the APIClient.

Notes:

Notice that SwiftyJSON should be only used in the consumer side, to easily parse dictionaries returned by the serializer.

Risk:

High