search

rootwork / bash-scripts

Some simple bash scripts for image/video conversion, image management, and video editing.
GNU Affero General Public License v3.0
3 stars 1 forks source link

Flags w/arguments broken when using short+long #3

Open rootwork opened 2 years ago

rootwork commented 2 years ago

boilerplate/options.sh uses getopts, mostly from Schotts' example, with the addition of long versions (e.g. both -t and --time).

While this works with both short and long options in general, it seems to break for short options when the option is more than a boolean and requires an argument (e.g. --time=5 works; -t=5 doesn't).

Other variants I had found worked with space-separated arguments (instead of =) but worked either with short or long options, not both. Another option would be to have no argument-based flags, and only accept these as position-based arguments the way we're doing with videos/markvid.sh and videos/trimvid.sh.

Investigate if there are better solutions.

Scripts this affects (i.e. currently-broken short options with arguments): images/imagedate.sh, images/modimg.sh, videos/fadevid.sh, videos/minsmvid.sh.

rootwork commented 2 years ago

Update: It seems like in some cases the long option works and the short doesn't, but in other cases it's vice versa. So there's definitely a bug somewhere.