ropensci-archive / MODISTools

Repository moved
https://github.com/bluegreen-labs/MODISTools/
Other
50 stars 26 forks source link

Vignette fail - check workflow #42

Closed khufkens closed 2 years ago

khufkens commented 2 years ago

Unsure why this happens as normally no external data is called for documentation might be idiosyncratic CRAN stuff.


Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_MODISTools.html.

Please correct before 2022-04-03 to safely retain your package on CRAN.

It seems we need to remind you of the CRAN policy:

'Packages which use Internet resources should fail gracefully with an informative message if the resource is not available or has changed (and not give a check warning nor error).'

This needs correction whether or not the resource recovers.

The CRAN Team

khufkens commented 2 years ago

Seems to be ORNL issue with new API features, which fails on calling all products. Seems some references in the vignette are to actual calls, which I'll change (wrap with try or set chunk to eval = FALSE, not sure yet).

https://modis.ornl.gov/rst/globalsubset_ui/#!/products/get_products

khufkens commented 2 years ago

fixed per: https://github.com/ropensci/MODISTools/commit/4eefaf89d032e1b29608cd2e1132e328cba26721

new submission to CRAN required