ropensci-archive / RMendeley

:no_entry: ARCHIVED :no_entry: Interface to Mendeley API methods
43 stars 6 forks source link

Updating all functions to new ROAuth #5

Closed karthik closed 12 years ago

karthik commented 12 years ago

In the master branch, all the new user specific methods use the new ROAuth. The ones ones don't. They could all be streamlined to the new format (thus avoiding issues down the line as oauth evolves). Since RMendeley is functional and on CRAN, I created a dev branch to add in all the new changes. Once this is complete and working, I can merge it back to master.

Carl: What do you think? Although it is assigned to you, I'll do this (but you can see what I mean by comparing one of the old functions to one of the new (working) functions).

cboettig commented 12 years ago

Hmm, document(".") fails on master since a bunch of the documentation is incomplete (breaks the install of master since the collate field of the description isn't updated). Is this completed on the dev branch?

Looks great, way to go. Anything specifically I should check/compare? i.e. did I have any user-specific methods before (other than in the demo/ dir?)

-C

On Thu, Mar 15, 2012 at 12:59 PM, Karthik Ram < reply@reply.github.com

wrote:

In the master branch, all the new user specific methods use the new ROAuth. The ones ones don't. They could all be streamlined to the new format (thus avoiding issues down the line as oauth evolves). Since RMendeley is functional and on CRAN, I created a dev branch to add in all the new changes. Once this is complete and working, I can merge it back to master.

Carl: What do you think? Although it is assigned to you, I'll do this (but you can see what I mean by comparing one of the old functions to one of the new (working) functions).

  • K

Reply to this email directly or view it on GitHub: https://github.com/ropensci/RMendeley/issues/5

Carl Boettiger UC Davis http://www.carlboettiger.info/

karthik commented 12 years ago

To avoid breaking document("."), I moved all the new functions to the dev branch so the master can stay clean and usable. I'm meeting Duncan on Friday so hopefully we will fix the problematic ones listed at the bottom of the dev tree README.

cboettig commented 12 years ago

Sounds good, keep me posted.

On Wed, Mar 21, 2012 at 12:43 PM, Karthik Ram < reply@reply.github.com

wrote:

To avoid breaking document("."), I moved all the new functions to the dev branch so the master can stay clean and usable. I'm meeting Duncan on Friday so hopefully we will fix the problematic ones listed at the bottom of the dev tree README.


Reply to this email directly or view it on GitHub: https://github.com/ropensci/RMendeley/issues/5#issuecomment-4625499

Carl Boettiger UC Davis http://www.carlboettiger.info/