search

ropensci-archive / bomrang

:warning: ARCHIVED :warning: Australian government Bureau of Meteorology (BOM) data client for R
Other
109 stars 26 forks source link

Improve test coverage #115

Closed adamhsparks closed 4 years ago

adamhsparks commented 4 years ago

Current coverage is only ~82% with no coverage for a few files. Notably the get_weather_bulletins() has none along with the new parse_()s.

adamhsparks commented 4 years ago

Test coverage is now ~91% with tests for all major functions except for the functions in dplyr.R

jonocarroll commented 4 years ago

Add # nocov to those lines if they are untestable.

https://github.com/r-lib/covr#exclusion-comments

adamhsparks commented 4 years ago

I don't know, they might be, I've not really looked into it too much yet so I didn't use the # nocov option yet

On Mon, 20 Jan 2020 at 09:49, Jonathan Carroll notifications@github.com wrote:

Add # nocov to those lines if they are untestable.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ropensci/bomrang/issues/115?email_source=notifications&email_token=AAYMIAQJDHUTPMD6NHMO2OTQ6TRJLA5CNFSM4KE7OMTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJK77WI#issuecomment-576061401, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYMIAXQMQKPAYISQ55F6S3Q6TRJLANCNFSM4KE7OMTA .

-- Dr Adam H. Sparks http://adamhsparks.netlify.com/ Associate Professor of Field Crops Pathology | Centre for Crop Health | Office C313

Phone (+61) 07 46311948 | Mobile 0415 489 422 | Twitter @adamhsparks https://twitter.com/adamhsparks

Institute for Life Sciences and the Environment | Research and Innovation Division University of Southern Queensland | Toowoomba, Queensland | 4350 | Australia