search

ropensci-archive / bomrang

:warning: ARCHIVED :warning: Australian government Bureau of Meteorology (BOM) data client for R
Other
109 stars 26 forks source link

Fix failing CRAN checks #116

Closed adamhsparks closed 4 years ago

adamhsparks commented 4 years ago
adamhsparks commented 4 years ago

get_historical() only gives an error message AFTER checking the server. I wasn't aware of this as the other bomrang functions should fail before any request is made, fail early, fail often. So I'd not included a skip_on_cran() in the error checking section of get_historical() tests.

This is fixed in https://github.com/ropensci/bomrang/commit/fa9c0462c85f701633537d8d533c8d2c0ac05746

adamhsparks commented 4 years ago

Issues with file caching should be fixed with this commit, https://github.com/ropensci/bomrang/commit/1a90dcd0ff93f302fb40b1238ff83b085e500618 where tempdir() is used for writing any files to avoid any issues with not having write access to ~/

adamhsparks commented 4 years ago

These should be fixed. It's passing local, R-builder and and rhub checks.

jonocarroll commented 4 years ago

Do you need that to be a flag?

https://github.com/ropensci/bomrang/blob/master/.github/workflows/main.yml#L52

sudo -E apt-get -yq --no-install-suggests ...
jonocarroll commented 4 years ago

Or if you want to be verbose, --yes --quiet.

adamhsparks commented 4 years ago

Good catch. But it's already been fixed in the devel branch.

https://github.com/ropensci/bomrang/blob/1a90dcd0ff93f302fb40b1238ff83b085e500618/.github/workflows/main.yml#L49