Closed jimjam-slam closed 3 years ago
The rainfall station list for 20 August 2020 is also empty, so maybe this isn't going to dix itself π
Are we sure itβs not just the drought? π€·ββοΈ
On 21 Aug 2020, at 11:31, James Goldie notifications@github.com wrote:
The rainfall station list for 20 August 2020 is also empty, so maybe this isn't going to dix itself π
β You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ropensci/bomrang/issues/119#issuecomment-677988230, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYMIAXFBJGNPIDY6PFSM2TSBXE53ANCNFSM4QETU2QA.
Running
debug(.get_ncc)
, it looks like this is a problem with lines 263-4 ofget_historical.R
: the list of rainfall stations published by the BOM is currently empty (I assume erroneously, because the temperature ones look fine), and because the resulting table parse attempt (starting line 230) ends up with less than 7 rows, line 264 crashes due to a subscripting error.I daresay this will fix itself once things settle on the BOM's end, but I'll try to work on a PR to make the function more robust (particularly since this crash happens even if someone isn't looking for rainfall data) in the morning!