search

ropensci-archive / bomrang

:warning: ARCHIVED :warning: Australian government Bureau of Meteorology (BOM) data client for R
Other
109 stars 26 forks source link

get_historical() backward compatibility is broken #123

Closed adamhsparks closed 4 years ago

adamhsparks commented 4 years ago

I forgot to include a backwards compatible function for get_historical() when I revamped the function names to make them more uniform across the package.

adamhsparks commented 4 years ago

Should be fixed in https://github.com/ropensci/bomrang/commit/bcd3f74a826a32ef67a19d1e69722907bed058cb.

It works for me locally now. @paulr-bv to please confirm by installing the latest from Master. Sorry about that, but good catch.  🙏

paulr-bv commented 4 years ago

Thanks. Installed from Master again and now working as expected. ☺

From: "Adam H. Sparks" notifications@github.com Reply to: ropensci/bomrang reply@reply.github.com Date: Tuesday, 1 September 2020 at 5:54 pm To: ropensci/bomrang bomrang@noreply.github.com Cc: Paul Robertson paulr@beovista.com.au, Mention mention@noreply.github.com Subject: Re: [ropensci/bomrang] get_historical() backward compatibility is broken (#123)

Should be fixed in bcd3f74https://github.com/ropensci/bomrang/commit/bcd3f74a826a32ef67a19d1e69722907bed058cb.

It works for me locally now. @paulr-bvhttps://github.com/paulr-bv to please confirm by installing the latest from Master. Sorry about that, but good catch. 🙏

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ropensci/bomrang/issues/123#issuecomment-684527614, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG7QKK5WEYCAXEVZH655UZ3SDSSCRANCNFSM4QRMYPYA.