search

ropensci-archive / bomrang

:warning: ARCHIVED :warning: Australian government Bureau of Meteorology (BOM) data client for R
Other
109 stars 26 forks source link

Simplify URL handling #131

Closed adamhsparks closed 3 years ago

adamhsparks commented 3 years ago

Currently, we have several functions that all fetch data from BOM servers when supplied with a URL. I can't see any good reason for the duplication. One (or maybe two) functions to handle downloads should be sufficient and reduce complexity.

adamhsparks commented 3 years ago

There are FTP and http requests. Maybe one for each of these?

adamhsparks commented 3 years ago

As I look at this, it's becoming clear again why bomrang has this. There may be some room for improvement/streamlining but data requests due to the BOM web server structures are rather unique for each application.

adamhsparks commented 3 years ago

A singular approach at this point isn't the most ideal. Some room for simplification remains but in the interest of time and ensuring that the package's bugs are squashed I'll release a new release without this and possibly revisit in the future.