search

ropensci-archive / bomrang

:warning: ARCHIVED :warning: Australian government Bureau of Meteorology (BOM) data client for R
Other
109 stars 26 forks source link

Use `agrep` for partial naming in state names in `get_precis_forecast` and `get_ag_bulletin` #24

Closed adamhsparks closed 7 years ago

adamhsparks commented 7 years ago 
vic <- get_precis_forecast(state = "VIC") # okay
vic <- get_precis_forecast(state = "vic") # okay
vic <- get_precis_forecast(state = "vi") # Not okay
vic <- get_precis_forecast(state = "victoria") # Not okay - really!!?
HughParsonage commented 7 years ago

Just in case the package has a word limit 😛 https://codegolf.stackexchange.com/q/124621/18526

adamhsparks commented 7 years ago

Fixed in full in commit https://github.com/ToowoombaTrio/bomrang/commit/0b7deffd8d89bad947816091f688ed21c09e4047