search

ropensci-archive / bomrang

:warning: ARCHIVED :warning: Australian government Bureau of Meteorology (BOM) data client for R
Other
109 stars 26 forks source link

add weather bulletin field descrs to vignette #59

Closed mpadge closed 7 years ago

mpadge commented 7 years ago

Let me know if you'd like anything changed/improved/whatever. Note the new comment in the man entry for get_weather_bulletin() - today's 0900 WA has a rain value of "\2" instead of "2". I'd suggest if there's a typo, then the entered value ought not be judged as reliable, so this is appropriate behaviour, but let me know if you think otherwise. (Non-numerics could also be grepped away, taking care to leave "Tce" for rainfall, and "#" for cloud, but this should be so extremely rare that this ought not be necessary.)

Note also that I've done three simple sub commands to change names. I don't know how to do this any "tidier" with dplyr::rename_if/at(), but feel free to dplyr-ise it if you want.

I also tried to find the World Met Organisation standards for observations, but failed after > 2 hours of searching. They just detail the heights at which things are to be observed, and the nature of web bulb thermometers and stuff like that, so aren't really that insightful anyway.

adamhsparks commented 7 years ago

Thanks @mpadge. Everything looks good. I've updated the pkgdown site to correspond to the new documentation.

I've submitted it to JOSS now.