ropensci-archive / bomrang

:warning: ARCHIVED :warning: Australian government Bureau of Meteorology (BOM) data client for R
Other
109 stars 26 forks source link

Closes #3 #7

Closed HughParsonage closed 7 years ago

HughParsonage commented 7 years ago

Function now accepts latlon argument, returning current_weather of nearest station (in the internal table) with a message. Uses haversine_distance (as internal function) to calculate the distance to avoid dependencies on packages. Slightly less accurate but fine for this purpose.

Outstanding issues that are not in scope for this PR:

HughParsonage commented 7 years ago

I believe the patch diff failure spurious. Subsequent commit reduced total lines, even though coverage has increased. Coverage miss in current_weather is only achieved if the server is down (i.e. can't be reproduced).

adamhsparks commented 7 years ago

Thanks @HughParsonage

Merged.