search

ropensci-archive / bomrang

:warning: ARCHIVED :warning: Australian government Bureau of Meteorology (BOM) data client for R
Other
109 stars 26 forks source link

get_radar_imagery function arguments default #84

Closed deanmarchiori closed 6 years ago

deanmarchiori commented 6 years ago

PR #83 introduced a new function get_radar_imagery(). The only argument to this function is product_id which is required and defaults currently to 'NULL'. Given there is no sensible default value this can be removed and argument parsing in the function can be updated. This will ensure the argument does not appear optional to a user.

deanmarchiori commented 6 years ago

Resolved. Pushed to devel branch in commit https://github.com/ropensci/bomrang/commit/ef2a7cf65fc0e8232f8c86f7648738799b3b538f