ropensci-archive / crminer

:no_entry: ARCHIVED :no_entry: Fetch 'Scholary' Full Text from 'Crossref'
Other
17 stars 5 forks source link

make_file_path internal fxn: handle weird urls #44

Closed sckott closed 4 years ago

sckott commented 4 years ago

an example we have in the docs

dois_crminer_ccby3[40]
#> "10.1088/1742-6596/689/1/012019"
links <- crm_links(dois_crminer_ccby3[40], "all")
# crm_text(links, 'pdf')

example of calling crm_text is commented out cause it 404s, which is fine, but the file is not deleted on exit as it should be.

the url it gives is http://stacks.iop.org/1742-6596/689/i=1/a=012019/pdf - which causes a problem in the internal fxn make_file_path() which results in a filename of pdf