search

ropensci-archive / elasticdsl

:no_entry: ARCHIVED :no_entry: Elasticsearch DSL
Other
30 stars 6 forks source link

Review dplyr's filter boolean logic implementation. #11

Open statwonk opened 8 years ago

statwonk commented 8 years ago

I really like dplyr's filter(this | that) (and also filter(this %or% that), it'd be nice to implement that here.

sckott commented 8 years ago

can you give an example of what that looks like?

statwonk commented 8 years ago

For my own reference, this is where dplyr::filter lives, https://github.com/hadley/dplyr/blob/344d23c934c3a3c0e26aef4abfaf49a644cb0d5a/R/manip.r#L19

statwonk commented 8 years ago

filter_.tbl_df: https://github.com/hadley/dplyr/blob/19ae0ce5ef828a984ba04ae8a0741e768159eb66/R/tbl-df.r#L187

One key check has_names, input is an R-like predicate and shouldn't have names.