ropensci-archive / rflybase

:no_entry: ARCHIVED :no_entry: Interface to 'FlyBase'
Other
3 stars 1 forks source link

new function, need review esp. about dplyr dependency #6

Closed jcolomb closed 7 years ago

jcolomb commented 7 years ago

Description

I added a function to transform the flybase name into a string or a html element with links. The new function needs stringr and dplyr, I wanted your feedback on this: should we make dplyr a necessary dependency (as I did) or should I modify the function. Although a modification would not be very difficult at this point, we may need dplyr for other functions in the future, I would therefore prefer solution 2. In addition, we may directly use tidyverse instead of dplyr?

I also rename the function to have it start with "fb_" like the others.

Related Issue

none

Example

rflybase is used for: https://colomb.shinyapps.io/Flystockcleaner/ (NB: need to install rflybase from my repo for it to work)

It looks great is'nt it? :)

sckott commented 7 years ago

nice, thanks @jcolomb

first, can you merge upstream changes into your version so there isn't a conflict here

jcolomb commented 7 years ago

Done!

sckott commented 7 years ago

thans