ropensci-archive / roweb2

:no_entry: ARCHIVED :no_entry:
https://github.com/ropensci/roweb3
25 stars 72 forks source link

Table tests #688

Closed maelle closed 4 years ago

maelle commented 4 years ago

To avoid conflicts with #685, experimenting here.

Cc @mpadge

I'm copying what happens for ropensci.org/packages, with Row details to display more information. I first thought about adding some sort of card on hover, but I prefer this solution.

Rows are expanded when clicking on the closed book. Most citations have a clickable link "built-in" by @sckott but some don't so I use the DOI column to add a link shown by a link emoji. I only kept citations with a DOI (therefore excluding blog posts).

Several questions

sckott commented 4 years ago
stefaniebutland commented 4 years ago

As I said on Slack, the content this table provides is amazing.

In all cases, do we want to show more information?

We don't want to duplicate the packages page (you brought this up in the mtg and I woke up Thurs am worried about this :-)) and it fits well in page now. 💡right above this table should say something like "Text to describe this table. For a full list of rOpenSci packages including their peer-review status, see our Packages page.

stefaniebutland commented 4 years ago

Question: for data sources like "NCBI, ENSEMBL, UniProt" each has a different link. Is it possible to have each of those linked to source?

maelle commented 4 years ago

Yes, and easier for me if the info is stored in a nested JSON then @sckott @mpadge

maelle commented 4 years ago

Thanks @sckott @stefaniebutland

I made a few tweaks. I'll keep working a bit on this branch before adding it to the other PR.

maelle commented 4 years ago

Note to self: explore making more hidden fields available for search like we do for the packages page (e.g. keywords).

stefaniebutland commented 4 years ago

getting DOI not found errors

This DOI cannot be found in the DOI System.

It includes a trailing slash character which may be wrong. Click here to resolve the DOI without the slash.

e.g. see

stefaniebutland commented 4 years ago

Open Software Peer Review

stefaniebutland commented 4 years ago

I removed DOIs and DOI links from the citations so only my "link emoji link" gives the DOI now.

Open question: Is keeping the DOI link visible and not using emoji more recognizable to audience who sees DOI links in journals so recognizes their value?

maelle commented 4 years ago

@stefaniebutland Thank you! I implemented all changes except for the location of the peer-review mention because some packages have so many citations that the software peer-review would be hidden. Maybe we should find a compromise making peer-review status some emoji like on the packages page?

@mpadge I used your table, thank you!

{
  "package": "blabla",
  "data_source": [
    {
      "name": "cool",
      "url": "url1"
    },
    {
      "name": "great",
      "url": "url2"
    }
  ]
} 

Otherwise is the goal to have the

maelle commented 4 years ago

Now when searching the "keywords" and "citations" fields are available so you'll get one package if you search for "secretome" or "France" (because of citations). You'll also get packages if you search for "unconf".

maelle commented 4 years ago

@mpadge @sckott @stefaniebutland candidate for review before I include it in the other PR (I won't do that until the data input format stops changing).

Mark's data has more packages, but now data source can be either name or URL, not both, and some rows have no "data source" (see e.g. MODIStsp). It's not a problem IMO, since the description of such packages if fine, and searching for MODIS would get the row which is the most important thing.

maelle commented 4 years ago

@mpadge what happened to cRegulome?

mpadge commented 4 years ago

@mpadge what happened to cRegulome?

it's still there, and seems intact to me

maelle commented 4 years ago

it's still there, and seems intact to me

it used to be truncated, sorry, no longer the case

maelle commented 4 years ago

I'll let @mpadge comment on these remarks since they're about the data we're feeding the table. Just a vague idea on "should we be finding a way to populate Data Source field where it's empty e.g. ccafs? (guessing source of that info comes from pkg authors)", maybe we should somehow merge "description" and "data source" for such cases?

stefaniebutland commented 4 years ago

should we be finding a way to populate Data Source field where it's empty e.g. ccafs? (guessing source of that info comes from pkg authors)

We decided to leave as is. Won't manually edit. Maëlle will open issue in dev guide to encourage pkg authors to have data source info in their pkg

maelle commented 4 years ago

https://github.com/ropensci/dev_guide/issues/260 🙂

maelle commented 4 years ago

@jeroen I'll use this PR as is in the post tomorrow unless you tweak it before then.

mpadge commented 4 years ago

Should https://docs.ropensci.org/tradestatistics/ should be in the table?

Absolutely! Yes, yes, and more yes!

maelle commented 4 years ago

I added it by hand at the moment but feel free to edit that 😁