Closed maelle closed 4 years ago
As I said on Slack, the content this table provides is amazing.
In all cases, do we want to show more information?
We don't want to duplicate the packages page (you brought this up in the mtg and I woke up Thurs am worried about this :-)) and it fits well in page now. 💡right above this table should say something like "Text to describe this table. For a full list of rOpenSci packages including their peer-review status, see our Packages page.
above table say total number of packages in table (I see it at bottom. Can it be moved to top? If not, add in text)
📕 my first impression was this was only an emoji. Need a (visual?) way to get people to click
is the 🔗 emoji redundant since the doi url is active? https://doi.org/10.1093/molbev/msw004 🔗
Question: for data sources like "NCBI, ENSEMBL, UniProt" each has a different link. Is it possible to have each of those linked to source?
Yes, and easier for me if the info is stored in a nested JSON then @sckott @mpadge
Thanks @sckott @stefaniebutland
I made a few tweaks. I'll keep working a bit on this branch before adding it to the other PR.
I decided to add the peer-review link when available, because it sounded better than telling readers to go read another table, and because I think it might add legitimacy like the citations. Feel free to disagree, I can remove it.
I added a small "Click for details" at the top of the column with emojis, and I added a small text before the table.
I removed DOIs and DOI links from the citations so only my "link emoji link" gives the DOI now.
Note to self: explore making more hidden fields available for search like we do for the packages page (e.g. keywords).
getting DOI not found errors
This DOI cannot be found in the DOI System.
It includes a trailing slash character which may be wrong. Click here to resolve the DOI without the slash.
e.g. see
Open Software Peer Review
I would put Open Software Peer Review.
below the citations. For audience for this post I think the citations carry more weight.
I would replace "Open Software Peer Review" -> "This package has passed open software peer review.", for clarity for intended audience.
I removed DOIs and DOI links from the citations so only my "link emoji link" gives the DOI now.
Open question: Is keeping the DOI link visible and not using emoji more recognizable to audience who sees DOI links in journals so recognizes their value?
@stefaniebutland Thank you! I implemented all changes except for the location of the peer-review mention because some packages have so many citations that the software peer-review would be hidden. Maybe we should find a compromise making peer-review status some emoji like on the packages page?
@mpadge I used your table, thank you!
{
"package": "blabla",
"data_source": [
{
"name": "cool",
"url": "url1"
},
{
"name": "great",
"url": "url2"
}
]
}
Otherwise is the goal to have the
Now when searching the "keywords" and "citations" fields are available so you'll get one package if you search for "secretome" or "France" (because of citations). You'll also get packages if you search for "unconf".
@mpadge @sckott @stefaniebutland candidate for review before I include it in the other PR (I won't do that until the data input format stops changing).
Mark's data has more packages, but now data source can be either name or URL, not both, and some rows have no "data source" (see e.g. MODIStsp). It's not a problem IMO, since the description of such packages if fine, and searching for MODIS would get the row which is the most important thing.
@mpadge what happened to cRegulome?
@mpadge what happened to cRegulome?
it's still there, and seems intact to me
it's still there, and seems intact to me
it used to be truncated, sorry, no longer the case
I'll let @mpadge comment on these remarks since they're about the data we're feeding the table. Just a vague idea on "should we be finding a way to populate Data Source field where it's empty e.g. ccafs? (guessing source of that info comes from pkg authors)", maybe we should somehow merge "description" and "data source" for such cases?
should we be finding a way to populate Data Source field where it's empty e.g. ccafs? (guessing source of that info comes from pkg authors)
We decided to leave as is. Won't manually edit. Maëlle will open issue in dev guide to encourage pkg authors to have data source info in their pkg
@jeroen I'll use this PR as is in the post tomorrow unless you tweak it before then.
Should https://docs.ropensci.org/tradestatistics/ should be in the table?
Absolutely! Yes, yes, and more yes!
I added it by hand at the moment but feel free to edit that 😁
To avoid conflicts with #685, experimenting here.
Cc @mpadge
I'm copying what happens for ropensci.org/packages, with Row details to display more information. I first thought about adding some sort of card on hover, but I prefer this solution.
Rows are expanded when clicking on the closed book. Most citations have a clickable link "built-in" by @sckott but some don't so I use the DOI column to add a link shown by a link emoji. I only kept citations with a DOI (therefore excluding blog posts).
Several questions