Dittodb post - Githubissues

ropensci-archive / roweb2

:no_entry: ARCHIVED :no_entry:

https://github.com/ropensci/roweb3

25 stars 72 forks source link

Dittodb post #718

Closed jonkeane closed 4 years ago

jonkeane commented 4 years ago

[x] I have read the Content Guidelines.
[x] I have read the Technical Guidelines.
[x] I used or followed the R Markdown or Markdown template.
[x] I have followed the Style Guide.
[x] I created or updated my author metadata with correct folder name.
[x] I have added relevant tags after browsing existing tags.
[x] I ran roblog::ro_lint_md() on index.md (optional).
[x] I ran roblog::ro_check_urls() on index.md (optional).
[x] I have added the tags - Software Peer Review, my-packagename, R.
[x] I have added the package-version YAML tag.
[x] I have added acknowledgement of the reviewers' work.
[x] I have added a link to the software peer review thread.

jonkeane commented 4 years ago

My audience for this post is folks who have a decent amount of R experience + some package development so I don't go into too much detail about the basics of object orientation, S4, etc. Though I could add that if the editors think it would be helpful to focus on a different audience. (or add in an explicit "this post is for you if you've developed a package before, even a simple one!" to the introduction)

This might be on the long side, I considered removing the section about traceing to shorten it, but decided to leave it in, at least for the draft. But if something needs to be cut, that was the first thing I was thinking.

stefaniebutland commented 4 years ago

Thank you @jonkeane! My colleague @steffilazerte will review.

jonkeane commented 4 years ago

Thank you so much for the really great comments, they have definitely improved this post.

I've accepted all of the changes — the only thing open at this point is the package version, I thought I had specified it appropriately in the YAML, but I don't see it referenced in the rendered page.

steffilazerte commented 4 years ago

That's great! I'll do the last pass soon (by early next week, if I don't get to it this week).

steffilazerte commented 4 years ago

Looks great! Thanks @jonkeane, we don't need anything else from you. We'll just merge on the publication date and you're good to go.

jonkeane commented 4 years ago

Thanks for all the super helpful comments!