search

ropensci-archive / wicket

:no_entry: ARCHIVED :no_entry: Utilities to Handle WKT Spatial Data
Other
9 stars 1 forks source link

format conventions #20

Closed mdsumner closed 4 years ago

mdsumner commented 7 years ago

A heads up, CRAN feedback on the WKT format:

https://github.com/r-gris/sfdct/issues/16

It seems you need a space between "POLYGON" and the first "(", for all types. I see wicket has a mix of usages in the vignette. I couldn't reproduce the problem on my systems, but you might ensure all your usages like "POLYGON((10 14" are "POLYGON ((10 14".

Interestingly this page is not consistent on the issue - but at any rate this might help catch future problems if they come up for you

https://en.wikipedia.org/wiki/Well-known_text

Ironholds commented 7 years ago

Thanks! This looks like an issue with boost geometry

Ironholds commented 7 years ago

Can you point me to the bit of the spec that requires a space?

mdsumner commented 7 years ago

Sorry, no idea - I can't find it but will come back if I learn more!

Ironholds commented 7 years ago

Please! I don't have any objection to changing it but if it's a mandatory thing I need to do it, and upstream, whereas if not..

mdsumner commented 7 years ago

Me too, it's just a heads up. I'm not asking anything. Sorry

On Fri, 1 Sep 2017, 09:22 Oliver Keyes notifications@github.com wrote:

Please! I don't have any objection to changing it but if it's a mandatory thing I need to do it, and upstream, whereas if not..

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ropensci/wicket/issues/20#issuecomment-326446128, or mute the thread https://github.com/notifications/unsubscribe-auth/AD6tb1RWDF2F5pIOvy3k9TY1ogi12NcIks5sd0BMgaJpZM4PFRyo .

-- Dr. Michael Sumner Software and Database Engineer Australian Antarctic Division 203 Channel Highway Kingston Tasmania 7050 Australia