consistency in bounding box ordering

ropensci-archive / wicket

:no_entry: ARCHIVED :no_entry: Utilities to Handle WKT Spatial Data

Other

9 stars 1 forks source link

consistency in bounding box ordering #8

Closed sckott closed 7 years ago

sckott commented 7 years ago

bounding_wkt expects min_x, max_x, min_y, max_y
wkt_bounding gives data back in min_x min_y max_x max_y

could these be in consistent order?

I don't think there's one golden standard for bounding boxes, but

GeoJSON spec has west, south, east, north
OSM has left,bottom,right,top

so those two are at least consistent

sckott commented 7 years ago

@Ironholds seems to not be totally fixed, with newest version:

bounding_wkt(values = list(c(10, 12, 14, 16)))
#> [1] "POLYGON((10 14,10 16,12 16,12 14,10 14))"
bounding_wkt(10, 12, 14, 16)
#> [1] "POLYGON((10 12,10 16,14 16,14 12,10 12))"

Ironholds commented 7 years ago

Oooh, that's weird. Okay, will work on.

Ironholds commented 7 years ago

New version:

library(wicket)

bounding_wkt(values = list(c(10, 12, 14, 16))) [1] "POLYGON((10 12,10 16,14 16,14 12,10 12))" bounding_wkt(10, 12, 14, 16) [1] "POLYGON((10 12,10 16,14 16,14 12,10 12))"