tests for ruby script - Githubissues

ropensci-org / badges

Badges for packages in rOpenSci software peer-review

3 stars 0 forks source link

tests for ruby script #4

Closed sckott closed 5 months ago

sckott commented 3 years ago

The script should ideally have tests. Some ideas:

use vcr for fixtures for github api data (via octokit) - so that we're not doing real http requests for tests
use some smaller subset of data, don't need all issues data
test that
- badge file names are correct
- svg content in badges is correct
- making badges correctly for regular review vs. stats review
- check that json data is formatted correctly and of write types, etc

sckott commented 3 years ago

Hmm, with a script it's hard to do proper testing. Could refactor script to use classes/modules, making testing way easier, but perhaps testing isn't really needed