ropensci-org / blog-guidance

rOpenSci Blog Guidelines for Authors and Editors (bookdown::git_book)
https://blogguide.ropensci.org/
9 stars 4 forks source link

document gallery shortcode #216

Open maelle opened 1 year ago

maelle commented 1 year ago

Fix #214

maelle commented 1 year ago

we'll have to wait a bit https://github.com/quarto-dev/quarto-cli/issues/5902

steffilazerte commented 1 year ago

Is this ready now?

maelle commented 1 year ago

well no because of the alternative text problem, I'm not sure we should advertise it right now.

maelle commented 2 months ago

@steffilazerte are you ok with Jeroen's answer in https://github.com/ropensci/roweb3/issues/666? (I tried two online checkers for https://ropensci.org/blog/2023/02/27/runiverse-discovering/ that found the alt text but using an actual screen reader might be a better test?)

steffilazerte commented 2 months ago

I think that's good enough for me, but @yabellini, do you think it would be appropriate to ask Liz to test it out for us so we can be absolutely sure?

The image gallery in this section should have a description for screen readers.

yabellini commented 2 months ago

I checked with WAVE (accessibility tool). The alt-text is there, and it is accessible.

image

yabellini commented 2 months ago

I also asked Liz to check the blog post if she have time, to be sure.

yabellini commented 2 months ago

Liz's test result:

Okay, first I'm going to test with Mac & Safari

Landing page stuff I hear Screenshot of R Universe search engine landing page, image." Link: search1.png "The right side of the search box contains expand button... " <this sounds like alt text?>

Link, search2.png Link, search3.png Link, search4.png

The last 3 don't have alt text.

When I open the links for each image, I don't get alt text in that view either.

So it looks like maybe the alt text for the first image is coming through-- or is that just regular text associated with the whole set of images? (You don't have to answer, the ? just means I'm not sure).

Now I'm going to try the same webpage with Chrome, because I think it offers more ways to get at descriptions, although I don't use it nearly as often as Safari.

Interesting-- on https://ropensci.org/blog/2023/02/27/runiverse-discovering/#level-1-searching-the-entire-r-ecosystem the behavior is the same for Chrome and Safari, but when I click the link for "search3.png", the dialog that pops up does tell me those are "unlabelled images." (For each image, , it says something like ""slash, search3.png, unlabelled image."

So, I'm sorry to say that the alt texts aren't getting added, except possibly for the first one in the gallery.

jeroen commented 2 months ago

So as I understand it, the screenreader did find the alt text on the thumbnail images in the document, however we need to protect it against following the link which opens the lightbox widget. So I tried to fix this in https://github.com/ropensci/roweb3/commit/f157317d3adddf81d645eaccccc3846299ef1966

yabellini commented 2 months ago

The text that the screen reader finds is the first image of the blog that is not in the carousel or gallery. Didn't find any of the alt-text in the gallery/carrousel.

jeroen commented 2 months ago

I think it is fixed now. I think what happened above is that she opened the lightbox and subsequently started navigating through the lightbox images. Now that the lightbox link is disabled the screen reader should just navigate through the thumbnails with alt text.

yabellini commented 2 months ago

Thanks @jeroen, I will ask to check the fix.
By the way, Liz also said about the blog post, "The text is excellent at describing how the website works. It's great that so much information is in the text, which is accessible."