search

ropensci-org / buffy

Editorial bots generator
https://buffy-ropensci.readthedocs.io/en/latest/
MIT License
1 stars 2 forks source link

Mint responder #28

Closed xuanxu closed 3 years ago

xuanxu commented 3 years ago

New MintResponder to grade stats submissions. This PR is issued against the approve-responder, so ideally should be merged before the PR #27, but it can also be merged later changing the base PR branch to ropensci. Closes #26

Screenshot of the docs: docs

mpadge commented 3 years ago

This looks great! I don't see any issues here, nor does it conflict with my comment about #27. Great stuff!

maelle commented 3 years ago

@xuanxu now that @mpadge has had a look, I think it can be merged, right? Thank you!

xuanxu commented 3 years ago

@maelle yes, this is merge-ready

mpadge commented 3 years ago

@maelle yes, this is merge-ready

@xuanxu I'm not quite sure, because approve_responder.rb has this:

     if ["bronze", "silver", "gold"].include?(statsgrade)
          labels_to_add << "6/approved-#{statsgrade}"

but those labels_to_add need to be extracted from the external service, right? So they are like "6/approved-silver-v0.0.1".

Edit: @xuanxu I just saw your comment here - will adding the external service call to the above approve_responder lines enable labelling with badge grades to work? Is there anything else that needs doing?

xuanxu commented 3 years ago

@mpadge This PR is ready to merge, it just adds the badge grade value to the body of the issue. So minting will work. What won't work is the actual labeling when approving the package (the code in the other PR), because the ApproveResponder is not (yet) calling the external service. Nothing to do on your part, I've tested the external service and it is working as expected, so the only missing piece is just adding the call to the ApproveResponder. I'll try to have it ready ASAP.