Custom responder to make the check package command runnable by all usernames mentioned in the reviewers and authors (author1, author-others, reviewers-list)

[maelle]

@xuanxu could we tweak the configuration so that the check package command is runnable by all usernames mentioned in the reviewers and authors (author1, author-others, reviewers-list)? I.e. is that possible?

[xuanxu]

Currently, changing permissions to a different list of users for each issue can't be done in the configuration. The way to do it would be to create a custom responder with the access rules specified there instead of using a regular responder.

[maelle]

Thank you! To me it sounds worthwhile but I'd wait until @mpadge has had a chance to chime in.

[mpadge]

Very easy from external service side to control all that, by modifying current template check fn to also extract all "authorised" users, and send on to check service if sender is in list.

[maelle]

Thanks! But for the sake of consistency, shouldn't the external service not do this kind of responder things? :thinking:

In particular the help command wouldn't list the package check command as it wouldn't really know the user can run it?

(no urgent answer required @mpadge)

[xuanxu]

I think is better to have that logic in the responder, listing all sources for authorized users in the issue body (reviewers-list, author, editor...)

[maelle]

I'd be in favor of having the logic in the responder, would that be ok with you @mpadge?

[mpadge]

Definitely okay! I too think that that is best

[maelle]

Thanks @mpadge!

@xuanxu this is becoming a feature request for you then. :smile_cat:

I edited the issue title.

[mpadge]

This is all done now via the above commits; thanks @xuanxu and @maelle.