issue with team creation

ropensci-org / buffy

Editorial bots generator

https://buffy-ropensci.readthedocs.io/en/latest/

MIT License

1 stars 2 forks source link

issue with team creation #53

Closed maelle closed 2 years ago

maelle commented 2 years ago

https://github.com/ropensci/software-review/issues/486#issuecomment-1011139556

@xuanxu this user was already in the GitHub organization. Could this have messed up the team invitation?

maelle commented 2 years ago

The team had been created, and had admin access to the repo.

maelle commented 2 years ago

I have checked the issue, the author1 is in there.

xuanxu commented 2 years ago

I think I found the cause: Currently the responder only invites the author to the team if it creates the team. If the team already exists no invitation is issued. Is it posible that the gittargets was already created before finalizing tranfer?

Anyway, I guess we should change that behavior and make the responder invite the author in every case, right?

maelle commented 2 years ago

Ah, maybe. @adamhsparks @wlandau, had one of you created the team?

And @xuanxu yes, it sounds like a good idea! Thanks for the debugging!

xuanxu commented 2 years ago

👍 Change pushed!

maelle commented 2 years ago

Thank you!

adamhsparks commented 2 years ago

Sorry, I’ve not created any teams.

maelle commented 2 years ago

thanks @adamhsparks!

maelle commented 2 years ago

@xuanxu we have this case again

author already in organization
the finalize transfer command has created the team but not issued an invitation to the team

I fear the previous bug fix was not the right one.

maelle commented 2 years ago

https://github.com/ropensci/software-review/issues/475#issuecomment-1247317853