Airtable in responders

[maelle]

Gathering some thoughts. API equivalents coming.

• when assigning reviewers

  • if there is NOT a reviewer with the username in the reviewers-prod table, create an entry with their username as github field. In the answer remind the person to fill the volunteering form https://airtable.com/shrnfDI2S9uuyxtDw.
  • then in all cases
    • add the link to the issue in the field "current assignment"
    • add an entry in the reviews table with the issue id, issue link, a link to the reviewer, the package name.

• have a command that the editor can call with the link to the review issue comment

• when approving the package, clear the "current assignment" field of reviewers.

[maelle]

Maybe for submitting a review the easiest thing is to have the editor submit it. @ropensci-review-bot submit review <link to comment> time <8>.

I would expect editors to have to come to the issue to thank the reviewer with a non-bot answer anyway.

[maelle]

Created a test airtable base (duplicated the real base but without records) at https://airtable.com/tblEeFgNuJiyUoVT1/ The airtable base ID should be a parameter this way when things work I can replace it with the actual base ID, and I'd save a token of mine in the Heroku secrets.

when assigning reviewers (tweaking the reviewer assignment responder)

• listing all existing reviewers https://airtable.com/appJ3ZFvnT27TImCY/api/docs#curl/table:reviewers-prod:list
• if needed creating an entry with the person's username (and name + email from their GitHub profile if they are present) https://airtable.com/appJ3ZFvnT27TImCY/api/docs#curl/table:reviewers-prod:create
• to add the link to the current issue as current_assignment cf https://airtable.com/appJ3ZFvnT27TImCY/api/docs#curl/table:reviewers-prod:update (so one needs the ID of the reviewer record, that one would get either after listing all existing reviewers, or after creating it)
• to add an entry in the reviews table with the issue id, issue link, a link to the reviewer, the package name. For now there is no way to get the package name so use the issue title. something like if package name is defined in an issue comment in the issue body, use it; if not use the isuse title (later when submissions happen via a form the package name will always be available) https://airtable.com/appJ3ZFvnT27TImCY/api/docs#curl/table:reviews:create
• the message to thank reviewers for accepting to review should also have the sentence "If you haven't done so, please fill this form for us to update our reviewers records."

when approving the package (tweaking the approve responder)

• clear the "current assignment" field of reviewers. https://airtable.com/appJ3ZFvnT27TImCY/api/docs#curl/table:reviewers:update

New responder for submitting reviews

to be done by editors (cc @noamross: this way the editor can have a look at whether the review has all the info in particular reviewing time, and can add a human thank you)

@ropensci-review-bot submit review <review url> time 8

• add review URL and date and duration to the corresponding record of the reviews table (now how to know what reviewer and what date it was? does it make sense to use GitHub API to see who authored the comment that's at review URL?) https://airtable.com/appJ3ZFvnT27TImCY/api/docs#curl/table:reviews:update
• once all reviewers that were assigned have a review submitted, remove the label "3/reviewer(s)-assigned" and add the label "4/review(s)-in-awaiting-changes".

[maelle]

addendum for when assigning reviewers

create entries in the slack-invites table. One line per person, email and name from GitHub API, if no name in GitHub profile use username (GitHub username). Date = date of entry creation. Invited unchecked.

• as author1 use either author1 if that's in the issue body, or the submitter.
• as author-others entries, author-others from the issue body (there can be none).
• reviewers.

[maelle]

Also, once as many reviews as reviewers have been submitted via @ropensci-review-bot submit review <review url> time 8, the badge should be changed to 4/review-in-awaiting-changes

[maelle]

@xuanxu for the responder for submitting reviews it'd be nice if it could parse, for "height hours and a half", both 8.5 and 8,5.

[maelle]

Everything now implemented, thank you @xuanxu!