Closed yabellini closed 2 years ago
I'd suggest reading info from https://github.com/ropensci/roweb3/tree/main/data/team with R + adding a regular rebuild of this guide (for instance once a week) to ensure it does not get out-of-date again.
I'm happy to make a PR doing this if you @steffilazerte @yabellini agree
Sounds good! Thanks!
What about the screen shot with the photos? That was done a bit sneakily by me, (not a straight screenshot), but I think we could use the actual photo to make it?
What do you mean by sneakily? :grin:
And yes we could build something with the actual pics.
What do you mean by sneakily? :grin:
I use the inspect tool, then changed the dimensions/margins/rows etc. to fit all photos in a smaller space, then took the screen shot, so it's not a 'true' screen shot of what the page actually looks like :wink:
so, automatically this is what we can get. Maybe playing with the viewer width would help too. https://rstudio.github.io/webshot2/reference/webshot.html
@steffilazerte your call, I can understand it looks less good (but it's easier to keep up to date)!
webshot2::webshot(
"https://ropensci.org/about/",
expand = 5,
selector = "#team-staff-others"
)
webshot2::webshot(
"https://ropensci.org/about/",
expand = 5,
selector = "#alumni"
)
Created on 2022-07-27 by the reprex package (v2.0.1)
I like :-)
I think it's too big. It results in a lot of scrolling to get past it when the photos are supposed to supplement the text, not be the main feature.
I'd prefer one of the following:
Maybe 3?
Reg 1 the text won't need to be updated because it'll be automatically generated, that's easier.
Reg 2 the problem is that the groups like staff and advisors are not separated on distinct lines. :thinking:
Ah I see, I didn't see that change to auto updating :) But for 2 the idea would be to change ropensci.org, to make that happen. Not sure that's the best though!
It's fine, I already had to add IDs to div in ropensci dot org this morning to take the screenshots. Could you please explain what exactly you'd want to be on separate screenshots? The different rows? Would it be fine to have some duplication between the screenshots?
Okay, verdict is let's use the long, simple webshot screenshot, but let's try to shrink the image a bit more than previously to make it a bit smaller in the end. Thanks @maelle!
https://contributing.ropensci.org/intro.html