Quarto - Githubissues

ropensci-org / contributing-guidance

rOpenSci Community Contributing Guide

https://contributing.ropensci.org/

6 stars 5 forks source link

Quarto #80

Closed maelle closed 2 years ago

maelle commented 2 years ago

TODOS

[x] Find a good unique way to add the cover https://github.com/quarto-dev/quarto-cli/issues/1543
[x] Decision on screenshots
[x] Is the current code reading people's info and outputting it correct
[x] Check metadata
[x] Add scheduled weekly build

maelle commented 2 years ago

@steffilazerte @yabellini could you please already review this especially

the automatically generated text about team members
the size of the image.

I have removed the cover image with the alt text for now as the cover image is added by Quarto BUT I opened #81 so we can re-add the alternative text for the cover image as soon as it is implemented in Quarto.

This way if the tweaks you need regarding the text / image are not too big you can merge in my absence.

yabellini commented 2 years ago

I read the text about the staff members and looks correct.
The links to our profiles aren't working because of the automatic name of the preview link?

maelle commented 2 years ago

oh no I need to fix that indeed! good catch!

steffilazerte commented 2 years ago

Just a couple of comments:

In strategic advisors, Noam has his role at rOpenSci, but everyone else has their workplace, does this need to be updated on the website?
Laura DeCicco and Lincoln Mullen aren't linked to their websites, but they do exist on ropensci

Other than that, looks lovely!

maelle commented 2 years ago

For info

fs::dir_ls(glob = "*.Rmd")|> 
  purrr::map(~file.rename(.x, fs::path_ext_set(.x, "qmd")))

plus fixing the configuration file, will rename all Rmd.