search

ropensci-org / pkgreviewr

R package to facilitate rOpenSci package reviews.
https://docs.ropensci.org/pkgreviewr/
Other
38 stars 8 forks source link

usethis::use_github #27

Open maelle opened 6 years ago

maelle commented 6 years ago

usethis::use_github could replace step 3 of the review workflow

maelle commented 6 years ago

I take this back because it won't work for Windows users at the moment (ask me how I know this 😀 )

maelle commented 6 years ago

Now git2r dev version should work on Windows. I guess it's important for the article about pushing the review to GitHub (which I 💙 because screenshots make it seem less daunting for beginners I think!)

maelle commented 5 years ago

Note that no, one cannot push using git2r on Windows, so I take this back.

annakrystalli commented 5 years ago

I believe the latest version of git2r has solved these issues on all systems. I've added the requirement for the latest version. So will close for now.

maelle commented 5 years ago

No it hasn't! I still can't push

annakrystalli commented 5 years ago

Oh! Yes I got confused! Was thinking of the clone problems I was having! OK, I think I have that problem at the moment too. Lemme do a little test

annakrystalli commented 5 years ago

Yup, failing. Getting this message: 

✔ Creating GitHub repository
✔ Adding GitHub remote
✔ Pushing to GitHub and setting remote tracking branch
Error in git2r::push(r, "origin", "refs/heads/master", credentials = credentials) : 
  Error in 'git2r_push': error authenticating:

However:

use_github(protocol = "https")
✔ Setting active project to '/Users/Anna/Desktop/test_use_github'
● Check title and description
  Name:        test_use_github
  Description: 
Are title and description ok?
1: Yeah
2: Nope
3: No way

Selection: 1
✔ Creating GitHub repository
✔ Adding GitHub remote
✔ Pushing to GitHub and setting remote tracking branch
✔ Opening URL https://github.com/annakrystalli/test_use_github

WORKS! (it uses the PAT I believe)

Wanna try it on Windows?

annakrystalli commented 5 years ago

I do have an ssh key set up though 🤔

annakrystalli commented 5 years ago

Oh! I think it might be the 2FA! I think you can't use ssh if you're using 2FA?!

maelle commented 5 years ago

I promise nothing works on Windows, I tested many, many things. 😉 Now for pushing with R, I am just waiting for https://github.com/jeroen/gert to be mature.