search

ropensci-org / pkgreviewr

R package to facilitate rOpenSci package reviews.
https://docs.ropensci.org/pkgreviewr/
Other
37 stars 8 forks source link

add code of conduct stuff as html comments #51

Closed maelle closed 5 years ago

maelle commented 5 years ago

so they don't need to be deleted but are still readable?

annakrystalli commented 5 years ago

Definitely should add a CoC and contributing page. Not sure what you mean with as html comments?

maelle commented 5 years ago

Currently in the templates there's

https://github.com/ropenscilabs/pkgreviewr/blob/devel/inst/templates/editor-index#L59

I'd like to make that

<!--Please be respectful and kind to the authors in your reviews. The rOpenSci [code of conduct](https://github.com/ropensci/onboarding/blob/master/policies.md/#code-of-conduct) is mandatory for everyone involved in our review process.-->

so that users still read the sentence but do not need to delete it.

annakrystalli commented 5 years ago

Aha! I see. Nice idea. Do you think they need to delete it though? ie that there's a problem including it in a review report?

PS I totally misunderstood the initial comment...so now pkgreviewr has a code of conduct too! 😜

maelle commented 5 years ago

Yes I think otherwise it would be deleted because it's not part of the report?

annakrystalli commented 5 years ago

Ok coming back to this I'm still not sure about the: