search

ropensci-org / pkgreviewr

R package to facilitate rOpenSci package reviews.
https://docs.ropensci.org/pkgreviewr/
Other
37 stars 8 forks source link

Error when setting up a new editor review #79

Closed adamhsparks closed 1 year ago

adamhsparks commented 1 year ago 
> pkgreview_create("popecol/rangr",
                  review_parent = "~/Developer/GitHub/rOpenSci/reviews/",
                  template = "editor",
                  issue_no = 595)

Clones the repo to the correct directory but then errors with:

Error in pkgreview_getdata(pkg_dir = pkg_dir, pkg_repo, template = template,  : 
  object 'package_data' not found

The examples do the same when I run them as-is and put the repo in "~/Documents".

Pakillo commented 1 year ago

I'm finding the same problem. I think the error stems from using a now deprecated usethis function here (see https://github.com/r-lib/usethis/pull/1747). AFAIK there was nothing wrong with project_data, it was just an API change.

I tried and the problem could be fixed easily by adding the now removed usethis:::project_data() function as an internal function in pkgreviewr (e.g. at the end of utils.R), without having to rewrite anything else. Please let me know if you'd welcome a pull request with that fix.

annakrystalli commented 1 year ago

Thanks for digging into this @Pakillo ! I would ❤️ a pull request!