ropensci-org / rotemplate

pkgdown template for rOpenSci packages :nail_care: :sparkles:
https://docs.ropensci.org/rotemplate
Other
25 stars 6 forks source link

Header missing links on rtweet #74

Closed llrs closed 2 years ago

llrs commented 2 years ago

The other day I realized that on rtweet the buttons to reference, vignettes and articles are missing from the header.

Screenshot from 2022-01-14 12-50-59 of BaseSet Screenshot from 2022-01-14 12-50-50 of rtweet

I think this is not a problem of building the website, but it might be related to other peculiarities of the package(?). Thanks for providing these templates!

jeroen commented 2 years ago

Maybe try to remove this:

https://github.com/ropensci/rtweet/blob/afccbffbda77a7ba9a64152fd2100e127c6210a1/_pkgdown.yml#L9-L12

llrs commented 2 years ago

I thought rOpenSci ignored that argument as it was there before the template, but now that I removed it, it works again. Thanks!

maelle commented 2 years ago

I think we'd let you re-write the whole navbar so we can't override it. :thinking: Opinions @jeroen?

jeroen commented 2 years ago

Yes I think it makes sense to leave the navbar content customizable by the pkg author.