search

ropensci-review-tools / babelquarto

Renders a Multilingual Quarto Project (Book or Website)
https://docs.ropensci.org/babelquarto/
Other
30 stars 6 forks source link

feat: dropdown list for websites #29

Closed maelle closed 5 months ago

maelle commented 5 months ago

Fix #27 Fix #25

@joelnitta @beamilz would this look ok?

image

joelnitta commented 5 months ago

Assuming that the "Version in" part changes language (for example, in French when you go the French version of the website), yes! Looks great!

maelle commented 5 months ago

@joelnitta Thanks! no, sadly at the moment that text doesn't change. let me open an issue. would you mind trying this PR branch with your website? I got stuck at the renv part. :sweat_smile:

maelle commented 5 months ago

oh wait i see the regression, let me fix it before you try it! I forgot we had solved this.

maelle commented 5 months ago

@joelnitta actually for your website for instance it should work as we still have current_lang[[1]][["text"]]

joelnitta commented 5 months ago

Can confirm this looks good on my end!

image

maelle commented 5 months ago

thank you @joelnitta!

@beatrizmilz (got your username wrong the first time :woman_facepalming:), please let me know if you have a chance to try this out. I'll merge this next week.

maelle commented 5 months ago

I will merge this, but please open an issue if I need to tweak something!