'lintr::expect_lint_free()' fails when run by goodpractice

goodpractice is right, but I am having trouble getting a clean result of goodpractice.

If I have a minimal package with only this test:

test_that("Package style", {
  lintr::expect_lint_free()
})

Building on Travis CI passes fine.

However, when Travis script runs the next line, with the command goodpractice::gp(), I get this log error message:

It is good practice to

  ✖ checking tests ... Running ‘testthat.R’ ERROR Running the tests in

    ‘tests/testthat.R’ failed. Last 13 lines of output: >
    test_check("galb") ── 1. Error: Package style (@test-style.R#2)
    ────────────────────────────────── invalid 'path' argument
    Backtrace: 1. lintr::expect_lint_free() 2. lintr::lint_package(...)
    3. base::normalizePath(path, mustWork = FALSE) 4.
    base::path.expand(path) ══ testthat results
    ═══════════════════════════════════════════════════════════ [ OK: 0
    | SKIPPED: 0 | WARNINGS: 0 | FAILED: 1 ] 1. Error: Package style
    (@test-style.R#2) Error: testthat unit tests failed Execution
    halted

I expect the goodpractice::gp() test to work on Travis. When I run it locally, it also just works.

I hope you enjoy my thorough bug report and I hope I can wish you good luck to fix this :+1:

ropensci-review-tools / goodpractice

'lintr::expect_lint_free()' fails when run by goodpractice #139