ropensci-review-tools / goodpractice

Advice on R Package Building
https://docs.ropensci.org/goodpractice/
Other
465 stars 37 forks source link

CRAN Error #157

Closed KarinaMarks closed 5 months ago

KarinaMarks commented 2 years ago

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_goodpractice.html.

Apparently your package fails its checks in a strict Latin-1* locale, e.g. under Linux using LANG=en_US.iso88591 (see the debian-clang results).

Please correct before 2022-08-30 to safely retain your package on CRAN.

KarinaMarks commented 2 years ago

Commit fixes error for now b6c31d62ab3b0eca21224a307a51f55fcac2901f

Temporary fix to keep package on CRAN, needs a more appropriate fix than skipping the test!

mpadge commented 5 months ago

Fixed with https://github.com/ropensci-review-tools/goodpractice/commit/904fa4d5c426aedc0f8f91a4add75edf0e97718b