search

ropensci-review-tools / goodpractice

Advice on R Package Building
https://docs.ropensci.org/goodpractice/
Other
465 stars 37 forks source link

Aborting `goodpractice::goodpractice()` while running `covr` doesn't stop `cyclocomp` on Linux #158

Closed potoole7 closed 5 months ago

potoole7 commented 1 year ago

On Linux (see Sys.info() below), interrupting goodpractice::goodpractice() with Ctrl + C stops covr, but cyclocomp still tries to run, and requires a second Ctrl + C (other "tests"/packages don't run).

Not sure if this is something you'd like to fix but I just thought I'd let you know!

Sys.info()
                            sysname                                 release                                 version 
                            "Linux"                       "5.10.0-21-amd64" "#1 SMP Debian 5.10.162-1 (2023-01-21)" 
                           nodename                                 machine                                   login 
                           "debian"                                "x86_64"                              "paddy7wb" 
                               user                          effective_user 
                         "paddy7wb"                              "paddy7wb"
mpadge commented 5 months ago

rOpenSci has now taken over maintenance of this package, as part of which we're cleaning out old issues. @potoole7 I'll presume this is no longer an issue and close, but feel free to re-open if you want to pursue further. Thanks