ropensci-review-tools / goodpractice

Advice on R Package Building
https://docs.ropensci.org/goodpractice/
Other
465 stars 37 forks source link

Transition from crayon to cli #167

Closed olivroy closed 6 months ago

olivroy commented 6 months ago

Before : image

This PR:

image

Summary

Happy to answer questions

mpadge commented 6 months ago

Thanks @olivroy for this excellent improvement. Could you please remove codemeta.json from the PR? (Details there are system dependent, and will create a lot of merge conflicts.) Please also merge the latest NEWS.md, which has just been updated. I'm pretty sure once that's done, we should be good to merge. Please request a review from me when you're ready. Thanks!

olivroy commented 6 months ago

@mpadge Can't request review via gh (not a member), but I addressed your comments and fixed merge conflicts!

olivroy commented 6 months ago

Glad to see the package under rOpensci!