Closed olivroy closed 6 months ago
Thanks @olivroy for this excellent improvement. Could you please remove codemeta.json
from the PR? (Details there are system dependent, and will create a lot of merge conflicts.) Please also merge the latest NEWS.md, which has just been updated. I'm pretty sure once that's done, we should be good to merge. Please request a review from me when you're ready. Thanks!
@mpadge Can't request review via gh (not a member), but I addressed your comments and fixed merge conflicts!
Glad to see the package under rOpensci!
Before :
This PR:
Summary
Gets rid of crayon and clisymbols, both superseded by cli
cli::cat_rule()
is quite handy (you can pass many parameters to...
incat_rule()
https://cli.r-lib.org/reference/rule.html.Create clickable links to path in console (had to strip NA to make sure paths were correct. i.e.
{.path path/to/file.R:NA}
doesn't work. Makes output cleaner, see snapshotsUse more cli messaging for announcing which steps are taking place. e.g.
The change of character in snapshot only occurs because in non-interactive sessions, cli uses unicode(?) symbols only, but no change in interactive session.
Removed
x
argument fromgp_footer()
as it is unusedHappy to answer questions