search

ropensci-review-tools / pkgcheck

Check whether a package is ready for submission to rOpenSci's peer-review system
https://docs.ropensci.org/pkgcheck/
18 stars 6 forks source link

Add recs for obsolete_pkg_deps #107

Closed maelle closed 2 years ago

maelle commented 2 years ago

In https://github.com/ropensci-review-tools/pkgcheck/pull/69/files for each obsolete dep there was the name of the alternative. Or maybe there could be a link to the related dev guide section https://devguide.ropensci.org/building.html#recommended-scaffolding

mpadge commented 2 years ago

Good idea, and great opportunity to develop a new print method. One thing I've been ignoring until now is the ordering of print methods, which this will be be a perfect opportunity to address. Thanks!

mpadge commented 2 years ago

@maelle This has now been addressed through functionality demonstrated at https://github.com/ropensci-review-tools/pkgcheck/issues/44#issuecomment-974008803, right? Happy to close?

maelle commented 2 years ago

Yes!