search

ropensci-review-tools / pkgcheck

Check whether a package is ready for submission to rOpenSci's peer-review system
https://docs.ropensci.org/pkgcheck/
18 stars 6 forks source link

Fix snapshots of html outputs #111

Closed mpadge closed 2 years ago

mpadge commented 2 years ago

They include all sorts of .js src files that likely depend on machines, architecture, and other local idiosyncrasies. Have to remove any potentially machine-dependent stuff from html produced by rmarkdown:::render prior to snapshotting.

mpadge commented 2 years ago

@maelle FYI the closing commit above adds this clean-snapshots.R script which is absolutely necessary for cleaning html snapshots rendered with rmarkdown.

mpadge commented 2 years ago

Hmmm ... snapshots are still not stable :question: :confused:

maelle commented 2 years ago

what differences do you see? is it Pandoc? :sob:

mpadge commented 2 years ago

Can't see any coz haven't yet found time to reproduce, and it is only on github checks that this is happening. I don't think it's pandoc, but also have no idea (yet) what it actually is. I'll report back when i find out more

mpadge commented 2 years ago

That green tick above says it all. Finally fixed this, and hope never to have to debug anything like that again.