search

ropensci-review-tools / pkgcheck

Check whether a package is ready for submission to rOpenSci's peer-review system
https://docs.ropensci.org/pkgcheck/
18 stars 6 forks source link

Fix failing windows checks #159

Closed mpadge closed 1 year ago

mpadge commented 2 years ago

Example: https://github.com/ropensci-review-tools/pkgcheck/runs/7971977824?check_suite_focus=true#step:7:3976

The workflow on windows fails to install pkgstats, yet the pkgstats workflow works fine (example here), meaning that pkgstats is correctly installed there. It fails here when trying to run the setup-r-dependencies action which should just load pkgstats via remotes: https://github.com/ropensci-review-tools/pkgcheck/blob/5b0fa114074823c179f530a6469de885762991a7/DESCRIPTION#L48-L50

... and yet fails to do so.

mpadge commented 2 years ago

The cause is https://github.com/r-lib/pak/issues/407, so should be resolved by fixing that.

mpadge commented 1 year ago

All works once again.