ropensci-review-tools / pkgcheck

Check whether a package is ready for submission to rOpenSci's peer-review system
https://docs.ropensci.org/pkgcheck/
18 stars 6 forks source link

what do the current test files test? #66

Closed maelle closed 3 years ago

maelle commented 3 years ago

E.g. what is bg?

maelle commented 3 years ago

I can guess but I wonder whether it should be more explicit.

mpadge commented 3 years ago

Getting there, but iteratively. Started with pkgstats today, which went from 2 to 5 test files, and increased coverage by > 25%. Expanding and properly structuring these tests is next is line. Thanks for the incentive!

maelle commented 3 years ago

Even to start small, the message in

https://github.com/ropensci-review-tools/pkgcheck/blob/754a79b50287be9db8bc7e01dc3275498a3f85c6/tests/testthat/test-bg.R#L1

can only get more explicit :grin: