search

ropensci-review-tools / pkgcheck

Check whether a package is ready for submission to rOpenSci's peer-review system
https://docs.ropensci.org/pkgcheck/
18 stars 6 forks source link

Check fns #76

Closed mpadge closed 3 years ago

mpadge commented 3 years ago

@maelle This achieves most of the restructuring of individual tests. Your scrap test file is now much simpler, with the main check function still just listing any scrap, and then a single extra fn:

https://github.com/ropensci-review-tools/pkgcheck/blob/0e0d9c5dfbe979e4a03fb3a206d9d95bfe2d5dd4/R/check-scrap.R#L31-L46

The summary and print bits of the object created there take care of appearance in the corresponding methods. That's getting close to the state we want where additional checks are as easy as a pkgchk_ function to do the checks and a corresponding output_pkgchk_ function to convert to summary and print results. Just a few tweaks remaining to enable control over order of the output items in the final result.

codecov[bot] commented 3 years ago

Codecov Report

Merging #76 (390069c) into main (2e7c686) will increase coverage by 1.46%. The diff coverage is 67.88%.

:exclamation: Current head 390069c differs from pull request most recent head efaf48d. Consider uploading reports for the commit efaf48d to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   63.70%   65.16%   +1.46%     
==========================================
  Files          25       29       +4     
  Lines        1416     1490      +74     
==========================================
+ Hits          902      971      +69     
- Misses        514      519       +5
Impacted Files Coverage Δ
R/info-ci.R 0.00% <ø> (-8.26%) :arrow_down:
R/pkgcheck-methods.R 4.83% <14.63%> (+4.83%) :arrow_up:
R/check-ci.R 44.44% <44.44%> (ø)
R/check-scrap.R 40.90% <55.55%> (+10.90%) :arrow_up:
R/format-checks.R 85.22% <57.14%> (-1.56%) :arrow_down:
R/checks-srr.R 60.00% <60.00%> (ø)
R/check-pkgname-available.R 77.77% <62.50%> (+7.18%) :arrow_up:
R/checks-left-assign.R 63.63% <68.75%> (+9.79%) :arrow_up:
R/check-covr.R 78.57% <78.57%> (ø)
R/summarise-checks.R 98.00% <97.50%> (+10.96%) :arrow_up:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e7c686...efaf48d. Read the comment docs.