search

ropensci-review-tools / pkgcheck

Check whether a package is ready for submission to rOpenSci's peer-review system
https://docs.ropensci.org/pkgcheck/
18 stars 6 forks source link

Create nospace #78

Closed maelle closed 3 years ago

maelle commented 3 years ago

/style

maelle commented 3 years ago

/style

codecov[bot] commented 3 years ago

Codecov Report

Merging #78 (a8cf934) into main (1ef7235) will decrease coverage by 0.03%. The diff coverage is 26.66%.

:exclamation: Current head a8cf934 differs from pull request most recent head 2aea7b6. Consider uploading reports for the commit 2aea7b6 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   66.32%   66.28%   -0.04%     
==========================================
  Files          30       31       +1     
  Lines        1758     1759       +1     
==========================================
  Hits         1166     1166              
- Misses        592      593       +1
Impacted Files Coverage Δ
R/cache.R 82.75% <0.00%> (ø)
R/check-urls.R 45.61% <0.00%> (ø)
R/checks-srr.R 65.21% <0.00%> (ø)
R/format-checks.R 81.65% <0.00%> (ø)
R/info-call-network.R 93.93% <0.00%> (ø)
R/info-ci.R 0.00% <0.00%> (ø)
R/info-git.R 46.15% <0.00%> (ø)
R/nospace.R 0.00% <0.00%> (ø)
R/path-fns.R 90.00% <0.00%> (ø)
R/pkgcheck-bg.R 94.44% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ef7235...2aea7b6. Read the comment docs.

maelle commented 3 years ago

@mpadge it's unclear to me why

So I'll come back to this later.

maelle commented 3 years ago

Ah my ugly file was not a .R file!

maelle commented 3 years ago

/style