search

ropensci-review-tools / pkgcheck

Check whether a package is ready for submission to rOpenSci's peer-review system
https://docs.ropensci.org/pkgcheck/
18 stars 6 forks source link

Use Bootstrap alert div for "principles" in the vignette? #82

Closed maelle closed 3 years ago

maelle commented 3 years ago

https://getbootstrap.com/docs/4.0/components/alerts/ (same syntax for Bootstrap 3)

They should be rendered on the pkgdown website and just ignored elsewhere so it should be ok.

::: {.alert .alert-primary}
Any information needed when summarising or printing the check result should be returned from the main check function.
:::
mpadge commented 3 years ago

Sure; do you want to PR that?

mpadge commented 3 years ago

All good - i did it myself, just to clean this issue out. Thanks anyway.

mpadge commented 3 years ago

@maelle These don't seem to work - i'll re-open the issue and hope you'll be able to provide some further insight?